Skip to content

[Validator] Avoid TypeError and improve DX when null groups #49137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 7.4
Choose a base branch
from
Open

[Validator] Avoid TypeError and improve DX when null groups #49137

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eca9937
[Validator] Avoid TypeError and improve DX when null groups
alamirault Jan 27, 2023
cbeeaf3
[Validator] Avoid TypeError and improve DX when null groups
alamirault Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Validator] Avoid TypeError and improve DX when null groups
  • Loading branch information
@alamirault
alamirault committed Jan 29, 2023
commit cbeeaf399587d0ed7f0001aabb9967172931cec4
14 changes: 7 additions & 7 deletions src/Symfony/Component/Validator/Validator/RecursiveContextualValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,15 @@ public function getViolations()
*/
protected function normalizeGroups($groups)
{
if (\is_array($groups)) {
return $groups;
if (!\is_array($groups)) {
$groups = [$groups];
}

return [$groups];
if (\in_array(null, $groups, true)) {
throw new ValidatorException('Value in array of validation groups cannot be null.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be an InvalidArgumentException I suppose?
What about other types that are neither strings nor GroupSequence?
Also, since this is an improvement, it should target 6.3.

}

return $groups;
}

/**
Expand Down Expand Up @@ -419,10 +423,6 @@ private function validateClassNode(object $object, ?string $cacheKey, ClassMetad
}

foreach ($groups as $key => $group) {
if (null === $group) {
throw new ValidatorException('Value in array of validation groups cannot be null.');
}

// If the "Default" group is replaced by a group sequence, remember
// to cascade the "Default" group when traversing the group
// sequence
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy