[DependencyInjection] Only dump array keys when value is not a list #49472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Feb 21, 2023
When the value is a list, there is no point in dumping the keys.
|
While you're at PhpDumper, can you please send a PR to make all closures (function+fn) non-static? In 6.3, this is visual debt because they're declared in static methods only. |
|
Thank you @ruudk. |
ruudk
added a commit
to ruudk/symfony
that referenced
this pull request
Feb 21, 2023
As per request from @nicolas-grekas. symfony#49472 (comment)
nicolas-grekas
added a commit
that referenced
this pull request
Feb 21, 2023
This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Remove static from closures | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? |no | Deprecations? |no | Tickets | | License | MIT | Doc PR | As per request from `@nicolas`-grekas. #49472 (comment) Commits ------- 9a94e00 Remove static from closures
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
Feb 21, 2023
As per request from @nicolas-grekas. symfony/symfony#49472 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the value is a list, there is no point in dumping the keys.