[Finder] Workaround for the problem with rewind of FilterIterator with inner FilesystemIterator. #4993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some tests |
| abstract class FilterIterator extends \FilterIterator | ||
| { | ||
| /** | ||
| * This is a workorund for the problem with \FilterIterator leaving inner \FilesystemIterator in wrong state after rewind |
|
Any feedback yet? The new commit includes tests. |
fabpot
added a commit
that referenced
this pull request
Jul 27, 2012
Commits ------- ae6016c [Finder] Workaround for FilterIterator-FilesystemIterator-rewind issue Discussion ---------- [Finder] Workaround for the problem with rewind of FilterIterator with inner FilesystemIterator. Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #4922 Todo: - License of the code: MIT Documentation PR: - --------------------------------------------------------------------------- by stof at 2012-07-20T10:28:05Z Please add some tests --------------------------------------------------------------------------- by alebo at 2012-07-24T09:50:36Z Any feedback yet? The new commit includes tests.
|
I am afraid it is not working, see this example http://davidgrudl.com/tmp/appenditerator-finder.zip. |
joshtrichards
pushed a commit
to joshtrichards/symfony-finder
that referenced
this pull request
Apr 26, 2024
This PR was squashed before being merged into the 2.1 branch (closes #8127). Discussion ---------- [Finder] Fix unexpected duplicate sub path related AppendIterator issue Bug fix: yes New feature: no BC breaks: no Deprecations: no Tests pass: yes Fixes: symfony/symfony#4993 (comment) Todo: - License of the code: MIT > @dg: I am afraid it is not working, see this example http://davidgrudl.com/tmp/appenditerator-finder.zip. Commits ------- bc8fbf2 [Finder] Fix unexpected duplicate sub path related AppendIterator issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #4922
Todo: -
License of the code: MIT
Documentation PR: -