Skip to content

[HttpClient] Fix getting through proxies via CONNECT #50235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

[HttpClient] Fix getting through proxies via CONNECT #50235

merged 1 commit into from
May 5, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Spotted while trying to hit google via symfony proxy:start:

https_proxy=http://127.0.0.1:7080 php test.php

where test.php contains:

$client = new CurlHttpClient();

$r = $client->request('GET', 'https://google.com/');

dump($r->getStatusCode());
dump($r->getHeaders());
dump($r->getInfo('debug'));

@carsonbot carsonbot added this to the 5.4 milestone May 4, 2023
@stof
Copy link
Member

stof commented May 4, 2023

is there any way to have a test covering this to prevent regressions ?

@nicolas-grekas
Copy link
Member Author

I won't be able to add a test covering that because it requires an HTTPS endpoint. Of course we could add some network services, but that's going to be too time consuming to setup properly...

@nicolas-grekas
Copy link
Member Author

Of course, I would gladly accept a PR that adds the test if anyone reading is up to give it a try!

@nicolas-grekas nicolas-grekas merged commit d038a0e into symfony:5.4 May 5, 2023
@nicolas-grekas nicolas-grekas deleted the hc-proxy branch May 5, 2023 15:49
@fabpot fabpot mentioned this pull request May 7, 2023
Merged
This was referenced May 27, 2023
Merged
Merged
@renovate renovate bot mentioned this pull request Dec 27, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpClient Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @stof @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy