[Finder] Fix children condition in ExcludeDirectoryFilterIterator #50885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
792d7ca to
621f75f
Compare
This was referenced Jul 5, 2023
|
Thank you @mvorisek. |
fabpot
added a commit
that referenced
this pull request
Jul 31, 2023
…yFilterIterator" (derrabus) This PR was merged into the 5.4 branch. Discussion ---------- [Finder] Revert "Fix children condition in ExcludeDirectoryFilterIterator" | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #51162, revert #50885 | License | MIT | Doc PR | not needed This PR reverts #50885 because it did not fix a bug and instead introduced a regression described in #51162. Commits ------- 2fd4453 Revert "minor #50885 [Finder] Fix children condition in ExcludeDirectoryFilterIterator (mvorisek)"
fabpot
added a commit
that referenced
this pull request
Jul 31, 2023
* 5.4: Revert "minor #50885 [Finder] Fix children condition in ExcludeDirectoryFilterIterator (mvorisek)"
fabpot
added a commit
that referenced
this pull request
Jul 31, 2023
* 6.3: Revert "minor #50885 [Finder] Fix children condition in ExcludeDirectoryFilterIterator (mvorisek)"
fabpot
added a commit
that referenced
this pull request
Jul 31, 2023
* 6.4: Revert "minor #50885 [Finder] Fix children condition in ExcludeDirectoryFilterIterator (mvorisek)"
nicolas-grekas
added a commit
that referenced
this pull request
Jul 31, 2023
* 5.4: Update VERSION for 5.4.27 Update CONTRIBUTORS for 5.4.27 Update CHANGELOG for 5.4.27 Revert "minor #50885 [Finder] Fix children condition in ExcludeDirectoryFilterIterator (mvorisek)" CI: Disable Psalm's findUnusedBaselineEntry feature Remove 6.2 from the list of potential branch targets Bump Symfony version to 5.4.27 Update VERSION for 5.4.26 Update CONTRIBUTORS for 5.4.26 Update CHANGELOG for 5.4.26 Fix symfony/deprecation-contracts require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/php/php-src/blob/6091603b5350c1ca0e792a6da604e25e2a0121c8/ext/spl/spl_directory.h#L113
Original
isDirfollow symlinks, so this PR has no effect, but it avoids expensiveisDircall and makes the condition more correct.