Skip to content

[HttpClient] Fix TraceableResponse if response has no destruct method #51659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

maxhelias
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Use case : I've created an HttpClient mock that returns a response as an anonymous object implementing the interface. This anonymous object doesn't need the __destruct method and create this error.

Capture d’écran 2023-09-14 à 22 56 27

@carsonbot carsonbot added this to the 5.4 milestone Sep 14, 2023
@nicolas-grekas nicolas-grekas merged commit 0f6c37a into symfony:5.4 Sep 19, 2023
@maxhelias maxhelias deleted the destruct-response branch September 19, 2023 13:08
@nicolas-grekas
Copy link
Member

Thank you @maxhelias.

This was referenced Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy