Skip to content

[Routing] Fix routing collection defaults when adding a new route to a collection #51704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,12 @@ final public function host(string|array $host): static

return $this;
}

/**
* This method overrides the one from LocalizedRouteTrait.
*/
private function createRoute(string $path): Route
{
return (clone $this->route)->setPath($path);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<?php

namespace Symfony\Component\Routing\Loader\Configurator;

return function (RoutingConfigurator $routes) {
$collection = $routes->collection();
$collection
->methods(['GET'])
->defaults(['attribute' => true])
->stateless();

$collection->add('defaultsA', '/defaultsA')
->locale('en')
->format('html');

$collection->add('defaultsB', '/defaultsB')
->methods(['POST'])
->stateless(false)
->locale('en')
->format('html');
};
25 changes: 25 additions & 0 deletions src/Symfony/Component/Routing/Tests/Loader/PhpFileLoaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,31 @@ public function testLoadingRouteWithDefaults()
$this->assertSame('html', $defaultsRoute->getDefault('_format'));
}

public function testLoadingRouteWithCollectionDefaults()
{
$loader = new PhpFileLoader(new FileLocator([__DIR__.'/../Fixtures']));
$routes = $loader->load('collection-defaults.php');

$this->assertCount(2, $routes);

$defaultsRoute = $routes->get('defaultsA');
$this->assertSame(['GET'], $defaultsRoute->getMethods());
$this->assertArrayHasKey('attribute', $defaultsRoute->getDefaults());
$this->assertTrue($defaultsRoute->getDefault('_stateless'));
$this->assertSame('/defaultsA', $defaultsRoute->getPath());
$this->assertSame('en', $defaultsRoute->getDefault('_locale'));
$this->assertSame('html', $defaultsRoute->getDefault('_format'));

// The second route has a specific method and is not stateless, overwriting the collection settings
$defaultsRoute = $routes->get('defaultsB');
$this->assertSame(['POST'], $defaultsRoute->getMethods());
$this->assertArrayHasKey('attribute', $defaultsRoute->getDefaults());
$this->assertFalse($defaultsRoute->getDefault('_stateless'));
$this->assertSame('/defaultsB', $defaultsRoute->getPath());
$this->assertSame('en', $defaultsRoute->getDefault('_locale'));
$this->assertSame('html', $defaultsRoute->getDefault('_format'));
}

public function testLoadingImportedRoutesWithDefaults()
{
$loader = new PhpFileLoader(new FileLocator([__DIR__.'/../Fixtures']));
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy