[Form] Make FormPerformanceTestCase compatible with PHPUnit 10
#51881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FormPerformanceTestCase compatible with PHPUnit 10FormPerformanceTestCase compatible with PHPUnit 10
yceruto
approved these changes
Oct 6, 2023
fabpot
approved these changes
Oct 7, 2023
|
Thank you @derrabus. |
xabbuh
added a commit
that referenced
this pull request
Oct 9, 2023
This PR was merged into the 7.0 branch. Discussion ---------- [Form] Remove RunTestTrait | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Follows #51881 | License | MIT On 7.0, we can add the new return type directly and remove the trait introduced with #51881. Commits ------- 3f36287 Remove RunTestTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHPUnit 10,
TestCase::runTest()has a return type ofmixed. I'm adding the return type conditionally on the one class where we override this method.