[Validator] review: FR translation #54681
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -440,7 +440,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="113"> | |||
| <source>This URL is missing a top-level domain.</source> | |||
| <target state="needs-review-translation">Cette URL est dépourvue de domaine de premier niveau.</target> | |||
| <target>Cette URL est dépourvue de domaine de premier niveau.</target> | |||
There was a problem hiding this comment.
| <target>Cette URL est dépourvue de domaine de premier niveau.</target> | |
| <target>Cette URL ne contient pas de domaine de premier niveau.</target> |
Voire
| <target>Cette URL est dépourvue de domaine de premier niveau.</target> | |
| <target>Cette URL doit contenir un domaine de premier niveau.</target> |
It feels to me "dépourvue" add some reading complexity
WDYT ?
There was a problem hiding this comment.
I was wondering, and looked at other "is missing" usage but there is none...
Looking at other strings, they are either
- imperative like "doit être", "ne doit pas être" which suits better "doit contenir"
- affirmative like "n'est pas", "n'a pas" which suits better "ne contient pas"
I am not sure which one to choose here, if it's only personal I'd go with "doit contenir" which sounds natural for me - avoiding a negative form on the way. That's also why I left "est dépourvue" but I can understand it's not a word we are used to seeing in error.
Maybe having other opinions on that question can help to choose the best one.
a29bd82 to
a234992
Compare
|
Thank you @viviengaetan. |
This PR was merged into the 5.4 branch. Discussion ---------- Fix french translation | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Fix translation done in #54681 Commits ------- 0413610 Fix french translation
Validation of the new FR validor string