Skip to content

[FrameworkBundle] Exclude constraints from container #54887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented May 11, 2024

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #...
License MIT

Constraints should not be registered as services but since Constraints and Validators are usually in the same directory, constraints can not be excluded using the path but only via instanceof.

@carsonbot carsonbot added this to the 6.4 milestone May 11, 2024
@Tobion Tobion force-pushed the constraint-services branch from 0224ff2 to df6e3c3 Compare May 11, 2024 10:46
@javiereguiluz javiereguiluz changed the title [FramworkBundle] exclude constraints from container [FrameworkBundle] exclude constraints from container May 11, 2024
@lyrixx
Copy link
Member

lyrixx commented May 11, 2024

Hello, IIRC, I did the same patch in order to try, and I didn't work. Are you 100% sure it remove theses services from the container?

@OskarStark OskarStark changed the title [FrameworkBundle] exclude constraints from container [FrameworkBundle] Exclude constraints from container May 13, 2024
@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 15, 2024

This should use registerForAutoconfiguration instead, the current code defines a local-only rule, but I suppose you want to exclude constraints defined by apps, isn't it?

@lyrixx
Copy link
Member

lyrixx commented May 15, 2024

Note : I tested with registerForAutoconfiguration obviously

@fabpot
Copy link
Member

fabpot commented Mar 29, 2025

Closing as there is no more activity and the patch is not correct.

@fabpot fabpot closed this Mar 29, 2025
nicolas-grekas added a commit that referenced this pull request Mar 31, 2025
…tes, enums from the container (nicolas-grekas)

This PR was merged into the 7.3 branch.

Discussion
----------

[FrameworkBundle] Exclude validator constraints, attributes, enums from the container

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Instead of #54887

Commits
-------

4ae07d6 [FrameworkBundle] Exclude validator constrains, attributes, enums from the container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy