[Console] Skip broken tests on OSX #57619
Conversation
On OSX running the following command results in the test being abrutply terminated: ```shell ```
6107ac8 to
8668607
Compare
|
Experiencing the same issue on MacOS. In order to keep track of this and not skip the test indefinitely, should we have some bug report open on php-src linking to the test case? |
Wouldn't that require to narrow down the reproducer though? Linking to a framework test suite feels... lazy, especially since you cannot easily tell if it's the framework doing something wrong or PHP. |
|
Well, i just tried on 6.4 & 7.1, no problem on my side + PHP 8.3.9
macOS 14.5 (M1)
pcntl enabled ... maybe the last bugfix fixed the bug ? |
|
Still broken on my side even after upgrading (6.4, 7.1, 7.2 with latest PHP 8.2, 8.3) |
|
I have debugged the failures locally. The reason for the failure is that our handlers for the |
|
closing in favour of #57798, thanks for making us aware of this @theofidry |
On OSX running the following command results in the test being abrutply terminated:
I could narrow it down to
src/Symfony/Component/Console/Tests/ApplicationTest.php. I think this is a bug from the pcntl extensions as running any problematic test individual result in a successful test and I cannot find any static state that should interfere with this (at least at the Symfony code level).My observations are that the application instance, which is the
$this, of this closure, changes when executing the whole test case.I'm unsure where to start to report this to PHP and would appreciate some help there or at least to confirm this is not a Symfony issue but a PHP one.
Meanwhile I could observe this behaviour on different machines including @chalasr. So I'm proposing to disable those problematic tests for OSX meanwhile as otherwise the test suite is not even executable on OSX.
FWIW ran it with:
OSX: 14.5 (23F79) on M3
PHP: 8.3.8
pcntl enabled (compiled PHP with
--enable-pcntl)