[Security] pass the current token to the checkPostAuth() method of user checkers
#57773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 19, 2024
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | Fix #50650 |
| License | MIT |
|
👍 some testcase would be nice to have though |
|
tests added |
chalasr
approved these changes
Jul 20, 2024
checkPostAuth() method of user checkers
fabpot
approved these changes
Jul 25, 2024
|
Thank you @xabbuh. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jul 22, 2025
…ce::checkPostAuth() (nicolas-grekas) This PR was merged into the 7.2 branch. Discussion ---------- [Security] Fix added $token argument to UserCheckerInterface::checkPostAuth() | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT An added argument must be optional and must be declared using ``@param``, which will allow spotting all places that have to be updated in cascade. This PR fixes all that. Not sure how we messed up so badly in #57773 😅 Commits ------- c819110 [Security] Fix added $token argument to UserCheckerInterface::checkPostAuth()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.