Keep has check

symfony · VincentLanglet · Jun 23, 2024 · Jul 27, 2024 · Jul 27, 2024 · Jul 29, 2024
commit 9685160f2a48e634ef77ffb47b0ba8b6a77b6a51
@@ -66,7 +66,7 @@ private function getFirewallContext(Request $request): ?FirewallContext
                 /** @var FirewallContext $context */
                 $context = $this->container->get($contextId);
 
-                if ($context->getConfig()?->isStateless() && null === $request->isStateless()) {
+                if ($context->getConfig()?->isStateless() && !$request->attributes->has('_stateless')) {
                     $request->setStateless();
                 }
 

@@ -54,7 +54,7 @@ public function testGetListenersWithInvalidParameter()
         $this->assertEquals([[], null, null], $firewallMap->getListeners($request));
         $this->assertNull($firewallMap->getFirewallConfig($request));
         $this->assertFalse($request->attributes->has(self::ATTRIBUTE_FIREWALL_CONTEXT));
-        $this->assertNull($request->isStateless());
+        $this->assertFalse($request->attributes->has('_stateless'));
     }
 
     /** @dataProvider providesStatefulStatelessRequests */

diff --git a/src/Symfony/Component/HttpFoundation/Request.php b/src/Symfony/Component/HttpFoundation/Request.php
@@ -656,12 +656,8 @@ public function setStateless(bool $stateless = true): void
         $this->attributes->set('_stateless', $stateless);
     }
 
-    public function isStateless(): ?bool
+    public function isStateless(): bool
     {
-        if (!$this->attributes->has('_stateless')) {
-            return null;
-        }
-
         return $this->attributes->getBoolean('_stateless');
     }
 

diff --git a/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php b/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php
@@ -124,7 +124,7 @@ protected function createSubRequest(string $uri, Request $request): Request
         if ($request->getDefaultLocale() !== $request->getLocale()) {
             $subRequest->setLocale($request->getLocale());
         }
-        if (null !== $request->isStateless()) {
+        if ($request->attributes->has('_stateless')) {
             $subRequest->setStateless($request->isStateless());
         }
         if ($request->attributes->has('_check_controller_is_allowed')) {