[HttpFoundation][FrameworkBundle] Add BinaryFileResponse::setXSendfileHeader() and corresponding config option to help configure upload acceleration
#58162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8465ad4 to
37b2ffb
Compare
OskarStark
reviewed
Sep 5, 2024
…S`, `SYMFONY_TRUSTED_HEADERS`, `SYMFONY_TRUST_X_SENDFILE_TYPE_HEADER` and `SYMFONY_TRUSTED_HOSTS` env vars
…eHeader() and corresponding config option to help configure upload acceleration
37b2ffb to
afd4b3d
Compare
BinaryFileResponse::setXSendfileHeader() and corresponding config option to help configure upload acceleration
|
Let me withdraw this PR: X-Senfile-Type is coming from the RoR world, and requires the server to send an X-Accel-Mapping header anyway so there is always something to configure on the server-side (at least for nginx) See https://github.com/rack/rack/blob/main/lib/rack/sendfile.rb and https://mattbrictson.com/blog/accelerated-rails-downloads for more on the topic. |
|
See also #58181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #58161 (comment) (and embeds the corresponding commit for now)