switch from AppVeyor to GitHub Actions to run tests on Windows #58721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, sounds good guys 🙏 I discovered AppVeyor by searching why tests go away sometimes for no reason ^^ |
stof
reviewed
Oct 30, 2024
stof
reviewed
Oct 30, 2024
d12a878 to
4032018
Compare
0f29271 to
f606338
Compare
|
You did an amazing job, thank you very much. 🖖 |
nicolas-grekas
approved these changes
Nov 6, 2024
|
Wohoo! 🚀 Thanks for all the debugging work @xabbuh! Next step I will experiment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #58370 I tried hard but failed to get our test suite running with PHPUnit 11 on AppVeyor. @wouterj did a great job reviving an old branch and got it working on GitHub Actions in #58699. I picked his commit and rebased it on the
5.4branch so that we are able to have a consistent CI config throughout all maintained branches.