Skip to content

[WebProfilerBundle] Twig deprecations #58919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

[WebProfilerBundle] Twig deprecations #58919

merged 1 commit into from
Nov 19, 2024

Conversation

mazodude
Copy link
Contributor

@mazodude mazodude commented Nov 19, 2024 •
edited by OskarStark
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues N/A
License MIT

This fixes some twig deprecations in the Web Profiler Bundle.
Since twig/twig 3.15: Add explicit parentheses around the "??" binary operator to avoid behavior change in the next major version as its precedence will change in "@WebProfiler/Collector/notifier.html.twig" at line 141

Not entirely sure which branch this should go against. Also not sure if this is a bugfix as it isn't really a bug.
Please feel free to correct it

@carsonbot carsonbot added this to the 7.1 milestone Nov 19, 2024
@fabpot
Copy link
Member

fabpot commented Nov 19, 2024

To answer your question, it should be done on 5.4 as it qualifies as a "bug".