Skip to content

[DoctrineBridge] Fix Connection::createSchemaManager() for Doctrine DBAL v2 #58956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[DoctrineBridge] Fix Connection::createSchemaManager() for Doctrine DBAL v2 #58956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[DoctrineBridge] Fix Connection::createSchemaManager() for Doctrine D… 
…BAL v2

As the 6.4 symfony/doctrine-bridge is compatible with doctrine/dbal 2.13  we need to check for createSchemaManager existance and use getSchemaManager instead if necessary (like it's already done in the messenger component for instance)
  • Loading branch information
@neodevcode @nicolas-grekas
neodevcode authored and nicolas-grekas committed Nov 25, 2024
commit b8a8bd844c2a7eafc5b041570b41432c448b0d41
3 changes: 1 addition & 2 deletions src/Symfony/Bridge/Doctrine/SchemaListener/AbstractSchemaListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ abstract public function postGenerateSchema(GenerateSchemaEventArgs $event): voi
protected function getIsSameDatabaseChecker(Connection $connection): \Closure
{
return static function (\Closure $exec) use ($connection): bool {
$schemaManager = $connection->createSchemaManager();

$schemaManager = method_exists($connection, 'createSchemaManager') ? $connection->createSchemaManager() : $connection->getSchemaManager();
$checkTable = 'schema_subscriber_check_'.bin2hex(random_bytes(7));
$table = new Table($checkTable);
$table->addColumn('id', Types::INTEGER)
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy