[Form] Keep submitted values when keep_as_list option of collection type is enabled
#59910
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
keep_as_list option of collection type is enabled
2dde5d2 to
4619258
Compare
StevenRenaux
approved these changes
May 26, 2025
nicolas-grekas
approved these changes
Jun 4, 2025
yceruto
approved these changes
Jun 4, 2025
|
@xabbuh Does this sound good to you? |
xabbuh
added a commit
that referenced
this pull request
Jun 10, 2025
…eCat) This PR was merged into the 7.2 branch. Discussion ---------- [Form] Fix `keep_as_list` when data is not an array | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix part of #57430 | License | MIT The `CollectionType` handles not only arrays but also `ArrayAccess&Traversable`. However when setting its `keep_as_list` option, `array_values` would then be called and crash. To avoid this, this PR reindexes the data by getting its keys and unsetting them. This is because unsetting in a loop can produce counter-intuitive results; e.g. [`ArrayIterator` would skip indexes](https://www.php.net/manual/en/arrayiterator.offsetunset.php). Note that #57430 mentions another issue that would be fixed by #59910. Commits ------- 6c964e7 [Form] Fix `keep_as_list` when data is not an array
e1c2d57 to
78214dc
Compare
…ype is enabled Co-authored-by: mariecharles marie.charles@hetic.net
78214dc to
bac56de
Compare
welcoMattic
approved these changes
Jun 11, 2025
xabbuh
approved these changes
Jun 11, 2025
|
Thank you @kells64000. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
keep_as_listoption ofCollectionTypeis true, its entries lose their values when re-displaying the form with submitted data.This fix only concerns the 2nd point of the linked issue.