[Lock] Add LockKeyNormalizer
#60023
Open
[Lock] Add LockKeyNormalizer
#60023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89d05b7 to
d1cd6e1
Compare
| { | ||
| $key = (new \ReflectionClass(Key::class))->newInstanceWithoutConstructor(); | ||
| foreach ($key->__sleep() as $serializedField) { | ||
| (fn () => $this->$serializedField = $data[$serializedField])->bindTo($key, Key::class)(); |
There was a problem hiding this comment.
it should be more efficient to have one closure outside of the loop instead of many calls inside
There was a problem hiding this comment.
Read your comment again after 4 months – the loop is now inside the closure 👍 😄
stof
reviewed
Mar 28, 2025
src/Symfony/Component/Lock/Tests/Serializer/LockKeyNormalizerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
| @@ -5,6 +5,7 @@ CHANGELOG | |||
| --- | |||
|
|
|||
| * Add support for `valkey:` / `valkeys:` schemes | |||
| * Add `LockKeyNormalizer` | |||
There was a problem hiding this comment.
Shouldn't this be on a new 7.4 section?
There was a problem hiding this comment.
it should indeed be in a 7.4 section
OskarStark
reviewed
Jul 21, 2025
| use Symfony\Component\Serializer\Normalizer\DenormalizerInterface; | ||
| use Symfony\Component\Serializer\Normalizer\NormalizerInterface; | ||
|
|
||
| class LockKeyNormalizer implements NormalizerInterface, DenormalizerInterface |
There was a problem hiding this comment.
Maybe add @auhor and a description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Lock documentation mentions that the lock keys are serializable – however, it seems that's the case only if you're using native php serializer.
I'm proposing to add
LockKeyNormalizerto make the example in the docs work the same when using Symfony Serializer too.