-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Workflow] Add support for weighted transitions #60201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lyrixx
wants to merge
1
commit into
symfony:7.4
Choose a base branch
from
lyrixx:workflow-transition-weight
base: 7.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+621
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2a67c1
to
5f46eb6
Compare
bkosun
suggested changes
Apr 11, 2025
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
bkosun
suggested changes
Apr 11, 2025
5f46eb6
to
9a13aba
Compare
@bkosun Thanks for the review. I addressed your comments |
94noni
reviewed
Apr 13, 2025
src/Symfony/Component/Workflow/Validator/StateMachineValidator.php
Outdated
Show resolved
Hide resolved
94noni
reviewed
Apr 13, 2025
stof
reviewed
Apr 14, 2025
src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd
Outdated
Show resolved
Hide resolved
9a13aba
to
7758d3d
Compare
Thanks for the review, I addressed your comments, and also rebased. |
I don't get why the tests are broken:
since I put "require-dev": {
"symfony/workflow": "^7.4|^8.0", in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to handle complex workflow like:
Another example, based on https://demo-symfony-workflow.cleverapps.io/articles/show/1
workflow.webm