[VarDumper] Add support for adding more default casters to AbstractCloner::addDefaultCasters()
#60480
+85
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractCloner::addDefaultCasters()AbstractCloner::addDefaultCasters()
AbstractCloner::addDefaultCasters()AbstractCloner::addDefaultCasters()
stof
reviewed
May 19, 2025
mtarld
reviewed
May 20, 2025
ea86493 to
632335f
Compare
|
Hello everyone. Thanks for the review! I have addressed your comments. |
mtarld
approved these changes
May 20, 2025
fabpot
requested changes
May 30, 2025
| /** | ||
| * Adds default casters for resources and objects. | ||
| * | ||
| * Maps resources or objects types to a callback. |
There was a problem hiding this comment.
Suggested change
| * Maps resources or objects types to a callback. | |
| * Maps resources or object types to a callback. |
| * Adds default casters for resources and objects. | ||
| * | ||
| * Maps resources or objects types to a callback. | ||
| * Types are in the key, with a callable caster for value. |
There was a problem hiding this comment.
Suggested change
| * Types are in the key, with a callable caster for value. | |
| * Use types as keys and callable casters as values. |
| * | ||
| * Maps resources or objects types to a callback. | ||
| * Types are in the key, with a callable caster for value. | ||
| * Resource types are to be prefixed with a `:`, |
There was a problem hiding this comment.
Suggested change
| * Resource types are to be prefixed with a `:`, | |
| * Prefix types with `::`, |
632335f to
9f7504c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR let us to write better code, and we also get a better discovery