Skip to content

[PhpUnitBridge] Skip bootstrap for PHPUnit >=10 #60645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented Jun 3, 2025

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix symfony/recipes#1425 (comment)
License MIT

As suggested by @wouterj, this will skip the bootstrap file that is automatically required by the bridge's composer.json.

I'm not sure whether to skip the entire file or only the part that registers the DeprecationErrorHandler.

@carsonbot

This comment was marked as resolved.

@HypeMC HypeMC changed the base branch from 7.4 to 7.2 June 3, 2025 04:22
@HypeMC HypeMC modified the milestones: 7.4, 7.2 Jun 3, 2025
@stof
Copy link
Member

stof commented Jun 3, 2025

The part about configuring doctrine deprecations might still be useful.

@HypeMC HypeMC force-pushed the skip-bootstrap-for-phpunit-gte-10 branch from 1f84a82 to 36974c3 Compare June 3, 2025 12:04
@HypeMC
Copy link
Member Author

HypeMC commented Jun 3, 2025

@stof I've applied the condition only to the parts related to DeprecationErrorHandler.

@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit 47f3667 into symfony:7.2 Jun 4, 2025
18 of 24 checks passed
@HypeMC HypeMC deleted the skip-bootstrap-for-phpunit-gte-10 branch June 4, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy