Skip to content

fix low deps build #60650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

fix low deps build #60650

merged 1 commit into from
Jun 3, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 3, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.4 milestone Jun 3, 2025
@@ -20,7 +20,8 @@
"symfony/property-info": "^6.4|^7.0|^8.0"
},
"require-dev": {
"symfony/cache": "^6.4|^7.0|^8.0"
"symfony/cache": "^6.4|^7.0|^8.0",
"symfony/var-exporter": "^6.4.1|^7.0.1|^8.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to benefit from the fix in #52797

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR not needed: these deprecations should be silenced on deps=low

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a deprecation causing the failure:

There was 1 error:

1) Symfony\Component\PropertyAccess\Tests\PropertyAccessorTest::testGetValuePropertyThrowsExceptionIfUninitializedWithLazyGhost
Undefined array key 3

/home/runner/work/symfony/symfony/src/Symfony/Component/PropertyAccess/vendor/symfony/var-exporter/LazyGhostTrait.php:170
/home/runner/work/symfony/symfony/src/Symfony/Component/PropertyAccess/PropertyAccessor.php:436
/home/runner/work/symfony/symfony/src/Symfony/Component/PropertyAccess/PropertyAccessor.php:102
/home/runner/work/symfony/symfony/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php:1013

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, 👍

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit c1d73b1 into symfony:7.4 Jun 3, 2025
11 checks passed
@xabbuh xabbuh deleted the pr-60647 branch June 3, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy