Remove deadcode after the bump to PHP >= 8.4 #60666

nicolas-grekas · 2025-06-03T15:50:02Z

Q	A
Branch?	8.0
Bug fix?	no
New feature?	no
Deprecations?	no
Issues	-
License	MIT

OskarStark · 2025-06-03T15:56:57Z

Wow 🤩

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

stof · 2025-06-03T16:05:59Z

src/Symfony/Bridge/Doctrine/ManagerRegistry.php

@@ -45,34 +43,6 @@ protected function resetService($name): void

            return;


Isn't the if ($manager instanceof LazyObjectInterface) { above also dead code ? Or is there still a case where we use a LazyObjectInterface of var-exporter instead of a native lazy object on PHP 8.4+ ?

LazyObjectInterface is not deprecated, it's still used for lazy decorators, which is the remaining feature on the topic.

stof · 2025-06-03T16:10:50Z

src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php

@@ -177,7 +173,7 @@
        $prevCacheDir = false;
    }
 }
-$SYMFONY_PHPUNIT_REMOVE = $getEnvVar('SYMFONY_PHPUNIT_REMOVE', 'phpspec/prophecy'.($PHPUNIT_VERSION < 6.0 ? ' symfony/yaml' : ''));


are we really dropping support for older PHPUnit versions ? There is a difference between the default version and the supported versions.

older phpunit versions don't support PHP 8, but we bumped the bridge to PHP >= 8.1 (to keep using it when testing Symfony 6.4)

We'll need a proper cleanup to remove all code related to using older PHPUnit versions then. For instance, there is no need to remove the prophecy dependency in PHPUnit 9.6 anymore (as it is not installed by default anymore).
And we probably need a check on $PHPUNIT_VERSION to fail properly if the env variable specifies an unsupported PHPUnit version.

stof · 2025-06-03T16:14:07Z

src/Symfony/Component/Clock/DatePoint.php

-        }
-
-        return static::createFromFormat('U.u', \sprintf('%.6F', $timestamp));
+        return parent::createFromTimestamp($timestamp);


Can't we drop the method override entirely now that we don't need to polyfill it ?

the decoration remains for the static return type, which is more accurate than the native one

src/Symfony/Component/JsonStreamer/Read/LazyInstantiator.php

src/Symfony/Component/VarDumper/Caster/ResourceCaster.php

stof · 2025-06-03T16:27:09Z

src/Symfony/Component/VarExporter/Internal/LazyObjectTrait.php

-    }
+/**
+ * @internal
+ * @deprecated since Symfony 7.3


adding a @deprecated since Symfony 7.3 annotation that was not there before is suspicious to me.

added as a reminder this should removed while removing the deprecated traits
the annotation was not needed because @internal

src/Symfony/Component/VarExporter/ProxyHelper.php

src/Symfony/Component/VarExporter/README.md

nicolas-grekas

comments addressed @stof, thanks for the review!

nicolas-grekas · 2025-06-04T09:14:28Z

src/Symfony/Bridge/Doctrine/ManagerRegistry.php

@@ -45,34 +43,6 @@ protected function resetService($name): void

            return;


LazyObjectInterface is not deprecated, it's still used for lazy decorators, which is the remaining feature on the topic.

nicolas-grekas · 2025-06-04T09:15:11Z

src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php

@@ -177,7 +173,7 @@
        $prevCacheDir = false;
    }
 }
-$SYMFONY_PHPUNIT_REMOVE = $getEnvVar('SYMFONY_PHPUNIT_REMOVE', 'phpspec/prophecy'.($PHPUNIT_VERSION < 6.0 ? ' symfony/yaml' : ''));


older phpunit versions don't support PHP 8, but we bumped the bridge to PHP >= 8.1 (to keep using it when testing Symfony 6.4)

nicolas-grekas · 2025-06-04T09:15:43Z

src/Symfony/Component/Clock/DatePoint.php

-        }
-
-        return static::createFromFormat('U.u', \sprintf('%.6F', $timestamp));
+        return parent::createFromTimestamp($timestamp);


the decoration remains for the static return type, which is more accurate than the native one

nicolas-grekas · 2025-06-04T09:20:40Z

src/Symfony/Component/VarExporter/Internal/LazyObjectTrait.php

-    }
+/**
+ * @internal
+ * @deprecated since Symfony 7.3


added as a reminder this should removed while removing the deprecated traits
the annotation was not needed because @internal

src/Symfony/Component/VarExporter/ProxyHelper.php

src/Symfony/Component/VarExporter/README.md

…ekas) This PR was merged into the 8.0 branch. Discussion ---------- Remove deadcode after the bump to PHP >= 8.4 | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- 38e079e Remove deadcode after the bump to PHP >= 8.4

nicolas-grekas requested review from chalasr, dunglas and yceruto as code owners June 3, 2025 15:50

carsonbot added Status: Needs Review labels Jun 3, 2025

carsonbot added this to the 8.0 milestone Jun 3, 2025

nicolas-grekas force-pushed the deadcode branch from 46927a5 to b76b449 Compare June 3, 2025 15:55

mtarld reviewed Jun 3, 2025

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php Outdated Show resolved Hide resolved

nicolas-grekas force-pushed the deadcode branch from b76b449 to f6e929d Compare June 3, 2025 16:09

stof reviewed Jun 3, 2025

View reviewed changes

nicolas-grekas force-pushed the deadcode branch from f6e929d to b9ed11b Compare June 4, 2025 09:25

nicolas-grekas commented Jun 4, 2025

View reviewed changes

nicolas-grekas force-pushed the deadcode branch 2 times, most recently from 321cf79 to 38e079e Compare June 4, 2025 10:36

Remove deadcode after the bump to PHP >= 8.4

13706dd

nicolas-grekas force-pushed the deadcode branch from 38e079e to 13706dd Compare June 4, 2025 10:38

nicolas-grekas merged commit d8b20d5 into symfony:8.0 Jun 4, 2025
7 of 9 checks passed

nicolas-grekas deleted the deadcode branch June 4, 2025 10:39

		@@ -45,34 +43,6 @@ protected function resetService($name): void

		return;

Uh oh!

Remove deadcode after the bump to PHP >= 8.4 #60666

Remove deadcode after the bump to PHP >= 8.4 #60666

Conversation

nicolas-grekas commented Jun 3, 2025

Uh oh!

OskarStark commented Jun 3, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.