[FrameworkBundle] ensureKernelShutdown in KernelTestCase::tearDownAfterClass #60693
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
reviewed
Jun 4, 2025
7f3f2b0 to
de4c4d7
Compare
de4c4d7 to
c193b98
Compare
|
Thank you @cquintana92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes from #60564
This PR performs the following change: In
KernelTestCase, the kernel is shut down after every test, as per thestatic::ensureKernelShutdown()call in thetearDownfunction. However, if one was to perform any extra code in theirtearDownAfterClassand callgetContainer, it would boot up a new kernel, which would then be left dangling. The main issue with that is that when the next Test class is executed, there would already be a booted kernel, so it could happen that it was pointing to dangling resources.By adding this call to
static::ensureKernelShutdownin thetearDownAfterClass, we can ensure that no dangling kernels are left even after the test class has finished.