Skip to content

[DependencyInjection] Improve docblock on compile() #60732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

Crell
Copy link
Contributor

@Crell Crell commented Jun 6, 2025

Q A
Branch? 7.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

This is just a documentation fix to make the $resolveEnvPlaceholders parameter more self-explanatory. Its current form confused me greatly and I had it set wrong because I was confused.

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.4 for features / 6.4, 7.2, or 7.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I think this can go in 6.4, but I'm not 100% sure on our policy here.

@carsonbot carsonbot changed the title Improve docblock on compile() [DependencyInjection] Improve docblock on compile() Jun 6, 2025
@nicolas-grekas nicolas-grekas removed the Bug label Jun 6, 2025
@nicolas-grekas
Copy link
Member

Thank you @Crell.

@nicolas-grekas nicolas-grekas merged commit ac67b6a into symfony:6.4 Jun 6, 2025
8 of 9 checks passed
@Crell Crell deleted the patch-1 branch June 6, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy