[Console] Allow setting aliases & hidden via command name passed to the constructor #60739
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think not supporting it was done on purpose at the time as that special syntax was specifically introduced for |
|
@chalasr If that's the case, then it currently works as expected on all versions. The problem in #60394 is that I started using this for cases that don't include the Of course, this isn't the only possible approach, but I personally prefer this one since it doesn't require duplicating the alias handling logic in yet another place. That logic already exists in the |
270e21b to
c37baa8
Compare
c37baa8 to
03d612a
Compare
chalasr
approved these changes
Jun 7, 2025
|
Thank you @HypeMC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, setting an alias and/or marking a command as hidden via the name doesn't work when the name is passed as a constructor argument. For example:
This issue was noticed while working on #60394 as mentioned in the comment there: #60394 (comment).