-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Scheduler] Fix AsCronTask not passing arguments to command #60741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.3
Are you sure you want to change the base?
[Scheduler] Fix AsCronTask not passing arguments to command #60741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding/fixing this! Can you target 6.4?
Do you think you'd be up for adding some tests here to prevent a regression?
Test added. But branch was reverted to 7.3, because the problem was introduced in 7.3 (here #59711) Is it ok? |
Oh, my bad - so the problem doesn't exist < 7.3? |
Yes, it did not exist in <7.3 |
src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Messenger/DummyCommand.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! I'm not 100% sure of the issue with the one CI failure.
Not sure either. Before test fails there is log I suppose that the reason is that the |
Yeah, that's what I'm thinking It should be fixed once merged though. |
This MR fixes passing
AsCronTask
arguments toCommand
. Reproduced can be by following command. It wont receive--all
option or any other argument specified inAsCronTask
when executed by Scheduler.Fix description: When command name was found in
AsCommand
attribute then attributes were not appended to message definition due to missing brackets.