refactor: update MermaidDumper to accept direction as a parameter in …

…dump method
symfony · damienfern · Jul 4, 2025 · Jul 4, 2025 · Jul 4, 2025 · Jul 5, 2025
commit 96d1fdaeae5dcbfcb8f654bc3ceeeefdf6b4b499
@@ -76,8 +76,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return Command::FAILURE;
         }
 
-        $dumper = new MermaidDumper(MermaidDirectionEnum::from($direction));
-        $mermaidOutput = $dumper->dump($this->roleHierarchy);
+        $dumper = new MermaidDumper();
+        $mermaidOutput = $dumper->dump($this->roleHierarchy, MermaidDirectionEnum::from($direction));
 
         $output->writeln($mermaidOutput);
 

@@ -21,25 +21,21 @@
  */
 class MermaidDumper
 {
-    public function __construct(
-        private readonly MermaidDirectionEnum $direction = MermaidDirectionEnum::TOP_TO_BOTTOM,
-    ) {
-    }
-
     /**
      * Dumps the role hierarchy as a Mermaid flowchart.
      *
      * @param RoleHierarchyInterface $roleHierarchy The role hierarchy to dump
+     * @param MermaidDirectionEnum   $direction     The direction of the flowchart
      */
-    public function dump(RoleHierarchyInterface $roleHierarchy): string
+    public function dump(RoleHierarchyInterface $roleHierarchy, MermaidDirectionEnum $direction = MermaidDirectionEnum::TOP_TO_BOTTOM): string
     {
         $hierarchy = $this->extractHierarchy($roleHierarchy);
 
         if (!$hierarchy) {
-            return "graph {$this->direction->value}\n    classDef default fill:#e1f5fe;";
+            return "graph {$direction->value}\n    classDef default fill:#e1f5fe;";
         }
 
-        $output = ["graph {$this->direction->value}"];
+        $output = ["graph {$direction->value}"];
         $allRoles = $this->getAllRoles($hierarchy);
 
         foreach ($allRoles as $role) {

@@ -45,8 +45,8 @@ public function testDumpWithDirection()
         ];
 
         $roleHierarchy = new RoleHierarchy($hierarchy);
-        $dumper = new MermaidDumper(MermaidDirectionEnum::LEFT_TO_RIGHT);
-        $output = $dumper->dump($roleHierarchy);
+        $dumper = new MermaidDumper();
+        $output = $dumper->dump($roleHierarchy, MermaidDirectionEnum::LEFT_TO_RIGHT);
 
         $this->assertStringContainsString('graph LR', $output);
     }
@@ -92,7 +92,8 @@ public function testInvalidDirection()
     {
         $this->expectException(\TypeError::class);
 
-        new MermaidDumper('INVALID');
+        $dumper = new MermaidDumper();
+        $dumper->dump(new RoleHierarchy([]), 'INVALID');
     }
 
     /**
@@ -101,7 +102,8 @@ public function testInvalidDirection()
     public function testValidDirections(MermaidDirectionEnum $direction)
     {
         $this->expectNotToPerformAssertions();
-        new MermaidDumper($direction);
+        $dumper = new MermaidDumper();
+        $dumper->dump(new RoleHierarchy([]), $direction);
     }
 
     public static function dataProviderValidDirection()