Skip to content

[Console][QuestionHelper] add optional timeout for human interaction #61092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: 7.4
Choose a base branch
from
Open

[Console][QuestionHelper] add optional timeout for human interaction #61092

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a6c7b8f
QuestionHelper: add optional timeout for human interaction
janedbal Jul 10, 2025
81604c0
Adjust changelog
janedbal Jul 10, 2025
22d26cc
Fix issue with MEMORY streams, use stream_select only for Questions w…
janedbal Jul 10, 2025
10f08e2
Rather throw exception on incompatible stream, add test for it
janedbal Jul 10, 2025
7aa76ef
Make Question::setTimeout nullable to allow removing timeout
janedbal Jul 10, 2025
c27b960
Do not fail on unsupported stream to make it testable, improve timeou…
janedbal Jul 10, 2025
0f8e199
Fix test assertion
janedbal Jul 10, 2025
e41e1ec
Update src/Symfony/Component/Console/CHANGELOG.md
janedbal Jul 10, 2025
b519250
Update src/Symfony/Component/Console/CHANGELOG.md
janedbal Jul 14, 2025
f007083
Fix timeout typo
janedbal Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test assertion
  • Loading branch information
@janedbal
janedbal committed Jul 10, 2025
commit 0f8e199c38ea7da442d37860a487abf77c508500
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public function testAskTimeout()
$question->setTimeout(1);

$this->expectException(MissingInputException::class);
$this->expectExceptionMessage('Timed out.');
$this->expectExceptionMessage('Timed out after waiting for input for 1 second.');

try {
$startTime = microtime(true);
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy