[FrameworkBundle] Fix cache warmers tests #61101
Open
+45
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this target 6.4? |
|
The test was added by #52981 so the same branch should be targeted right? |
ff2ebd2 to
fb9e64e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating tests for #60568 I saw
SerializerCacheWarmerTestandValidatorCacheWarmerTest’stestWarmUpWithoutBuilDirfail. Since there will be no warm up without a build directory it was weird a cache item could get hit in that case.Turns out that was because the
PhpArrayAdapter’s$valuesCachewould retain them from previous tests.This PR adds a
getArrayPoolmethod to the test cases which allows them to clear it on tearDown, so that tests don’t impact each other. Alternatively they could clear their own adapter or pass it different files, but this seemed the safest approach to me.