Fix various bool-type coercions #61103
Conversation
This comment has been minimized.
This comment has been minimized.
| @@ -85,7 +85,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed | |||
| $setters = $value->getMethodCalls(); | |||
| $value->setMethodCalls($withers); | |||
| foreach ($setters as $call) { | |||
| $value->addMethodCall($call[0], $call[1], $call[2] ?? false); | |||
| $value->addMethodCall($call[0], $call[1], isset($call[2]) && $call[2]); | |||
There was a problem hiding this comment.
I would not change that, as we expect the third array value to be a boolean. Instead, we should fix the invalid usages of the method calls.
85f4d6a to
b3d30e3
Compare
|
Thank you @Girgias. |
| @@ -128,7 +128,7 @@ public function disableMagicSet(): static | |||
| */ | |||
| public function isMagicCallEnabled(): bool | |||
| { | |||
| return (bool) ($this->magicMethods & PropertyAccessor::MAGIC_CALL); | |||
| return $this->magicMethods & PropertyAccessor::MAGIC_CALL; | |||
There was a problem hiding this comment.
isnt this producing an integer now?
There was a problem hiding this comment.
see the return type, which cannot be bypassed
There was a problem hiding this comment.
The return type will create an implicit cast to bool, which is precisely what @Girgias tries to deprecated in PHP 8.5 AFAICT.
There was a problem hiding this comment.
correct, but this is not done yet :)
There was a problem hiding this comment.
i dont understand it, why would you want to rely on not using strict_types=1 currently? also, why opening up a deprecation, if the future fix is adding back (bool) again?
There was a problem hiding this comment.
Strict types was a bad idea that makes writing PHP more fragile, see https://github.com/Girgias/unify-typing-modes-rfc?tab=readme-ov-file#unintended-consequences-of-strict_types-mode
You might not agree but that's nonetheless the way Symfony does types.
The future is not adding back the cast. At least not before any vote happened on the topic.
So this change is just bringing consistency with the current policies.
There was a problem hiding this comment.
right, i understand the POV a bit better now.
that said
Use of explicit casts to conform to type requirements
im fine with explicitness :) i mean, psalm complains about it 😅
This is cherry-picking some of the commits from #60890 which are basically bugs.
Not sure what the commit naming policy is so do let me know if you want me to manually rebase and rename commits following some guidelines.