Fix Exception on empty JSON login: BadCredentials message too generic #61152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yashingle1307
commented
Jul 18, 2025
| Q | A |
|---|---|
| Branch? | 7.4 for features / 6.4, 7.2, or 7.3 for bug fixes |
| Bug fix? | yes/no |
| New feature? | yes/no |
| Deprecations? | yes/no |
| Issues | Fix #... |
| License | MIT |
…on on empty username/password
| @@ -147,7 +148,7 @@ private function getCredentials(\stdClass $data): array | |||
| $credentials['username'] = $this->propertyAccessor->getValue($data, $this->options['username_path']); | |||
|
|
|||
| if (!\is_string($credentials['username']) || '' === $credentials['username']) { | |||
| throw new BadRequestHttpException(\sprintf('The key "%s" must be a non-empty string.', $this->options['username_path'])); | |||
| throw new BadCredentialsException('The key "username" must be a non-empty string.'); | |||
There was a problem hiding this comment.
the default for option username_path is "username", so I'm missing what this PR provides. The resulting message will be exactly the same to me. And when one changes the value of the option, then the message might be considered less accurate actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.