Skip to content

[Validator] Remove exclusion of Constraints/Validator/ExpressionLanguageSyntaxValidator #61166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

corradogrimoldi
Copy link

@corradogrimoldi corradogrimoldi commented Jul 20, 2025

Q A
Branch? 8.0
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

🛠️ Validation Component removed the ExpressionLanguageSyntaxValidator so it is no longer loaded in the service container.
The method used to exclude the service stands on the fact that the class file exists, this cause an exception

@xabbuh
Copy link
Member

xabbuh commented Jul 20, 2025

Can you please explain a bit more what happens without this change? What error do you get?

@nicolas-grekas nicolas-grekas changed the title [Validator] Remove exclusion of Constraints/Validator/ExpressionLangu… [Validator] Remove exclusion of Constraints/Validator/ExpressionLanguageSyntaxValidator Jul 21, 2025
@symfony symfony deleted a comment from carsonbot Jul 21, 2025
@nicolas-grekas
Copy link
Member

I'm also wondering about how you experienced this @corradogrimoldi
Note that this PR should be merge on 8.0 for sure!
On 7.*, I'm unsure, since the bundle is compatible with Validation 6.4, where the excluded file exists.

@corradogrimoldi
Copy link
Author

@nicolas-grekas I'm using framework-bundle 7.3 and running composer require symfony/validator I got the 7.3 version and there ExpressionLanguageSyntaxValidator is not present.
Due to this, when I clear the cache, and reload the application, an exception is raised in vendor/symfony/config/FileLocator.php:

Symfony\Component\Config\Exception\FileLocatorFileNotFoundException: The file "/usr/local/apache2/htdocs/vendor/symfony/validator/Constraints/ExpressionLanguageSyntaxValidator.php" does not exist.

the exception is catched and due to the fact that $ignoreErrors is set to true, nothing happens to the app

@nicolas-grekas
Copy link
Member

So there's no bug, this is normal behavior and everything works, isn't it?

@nicolas-grekas nicolas-grekas modified the milestones: 7.3, 8.0 Jul 21, 2025
@nicolas-grekas nicolas-grekas changed the base branch from 7.3 to 8.0 July 21, 2025 07:42
@nicolas-grekas nicolas-grekas force-pushed the FIX-validator-expressionlanguage branch from 2fdfa85 to 5e61506 Compare July 21, 2025 07:42
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 8.0 as explained in #61166 (comment)

@nicolas-grekas
Copy link
Member

Thank you @corradogrimoldi.

@nicolas-grekas nicolas-grekas merged commit b1bc08a into symfony:8.0 Jul 21, 2025
7 of 9 checks passed
@corradogrimoldi
Copy link
Author

corradogrimoldi commented Jul 21, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy