[ObjectMapper] Remove deprecated LazyGhostTrait test
#61191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive lazy object coverage
d885541 to
200b231
Compare
xabbuh
reviewed
Jul 22, 2025
| @@ -371,14 +370,6 @@ public static function objectMapperProvider(): iterable | |||
| yield [new ObjectMapper(new ReflectionObjectMapperMetadataFactory(), PropertyAccess::createPropertyAccessor())]; | |||
| } | |||
|
|
|||
| public function testMapInitializesLazyObject() | |||
There was a problem hiding this comment.
I wonder if we need to rewrite the test instead to not use the LazyGhostTrait. The code that is tested by this method is still present: https://github.com/symfony/symfony/blob/8.0/src/Symfony/Component/ObjectMapper/ObjectMapper.php#L320-L321
There was a problem hiding this comment.
LazyObjectInterface is still used by interface-based proxies. That's likely what we need also on lower branches since it should allow writing code that'll work with all version. ProxyHelper::generateLazyProxy(null, [SomeInterace::class])
|
See #61197 instead. Thanks for proposing. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 22, 2025
…as-grekas) This PR was merged into the 7.3 branch. Discussion ---------- [ObjectMapper] Fix test using LazyObjectInterface | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Instead of #61191 and #61192 Commits ------- 168b3a3 [ObjectMapper] Fix test using LazyObjectInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
testMapInitializesLazyObjecttest, which relies on theLazyFoofixture that uses theLazyGhostTrait. This trait has been deprecated since Symfony 7.3( and removed in this version ), and it's now recommended to use native PHP lazy objects instead.The behavior previously tested by
testMapInitializesLazyObjectis already covered bytestMapInitializesNativePhp84LazyObject, using native PHP methods. Therefore, maintaining both tests is redundant.Additionally, the removed test is currently failing in the 8.0 branch pipelines, due to incompatibility with the deprecated
LazyGhostTrait( since this trait was removed in this branch)