Skip to content

[Security] Fix added $token argument to UserCheckerInterface::checkPostAuth() #61194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

An added argument must be optional and must be declared using @param, which will allow spotting all places that have to be updated in cascade. This PR fixes all that. Not sure how we messed up so badly in #57773 😅

@nicolas-grekas nicolas-grekas requested a review from chalasr as a code owner July 22, 2025 07:42
@carsonbot carsonbot added this to the 7.4 milestone Jul 22, 2025
@nicolas-grekas nicolas-grekas changed the base branch from 7.4 to 7.2 July 22, 2025 07:42
@nicolas-grekas nicolas-grekas modified the milestones: 7.4, 7.2 Jul 22, 2025
@symfony symfony deleted a comment from carsonbot Jul 22, 2025
@nicolas-grekas nicolas-grekas merged commit dabfa59 into symfony:7.2 Jul 22, 2025
11 checks passed
@nicolas-grekas nicolas-grekas deleted the sec-token branch July 22, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy