Skip to content

[HttpFoundation] Simplify UriSigner::verify to use match #61196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Jul 22, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #...
License MIT

Simplify UriSigner::verify to use match.

/cc @kbond what do you think?

@alexandre-daubois
Copy link
Member

FYI, improving code by refactoring it like this should target the feature branch, namely 7.4 🙂

@alexander-schranz alexander-schranz force-pushed the enhancement/simplify-verify-to-match branch from 2069169 to 6bc2719 Compare July 22, 2025 08:31
@alexander-schranz alexander-schranz changed the base branch from 7.3 to 7.4 July 22, 2025 08:31
@alexandre-daubois alexandre-daubois modified the milestones: 7.3, 7.4 Jul 22, 2025
@symfony symfony deleted a comment from carsonbot Jul 22, 2025
@carsonbot carsonbot changed the title Simplify UriSigner::verify to use match [HttpFoundation] Simplify UriSigner::verify to use match Jul 22, 2025
@nicolas-grekas
Copy link
Member

Thank you @alexander-schranz.

@nicolas-grekas nicolas-grekas merged commit 8150927 into symfony:7.4 Jul 22, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy