Remove some implicit bool type juggling #61203
Open
+107
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa22f7b to
1f6ddc5
Compare
1f6ddc5 to
62c139d
Compare
|
@nicolas-grekas shouldn't we do that work in 6.4, as we'll want to have support for PHP 8.5 in Symfony 6.4 due to our policy ? |
|
To me, that's comparable to CS fixes. PHP 8.5 might ship the deprecation, although vote is ongoing and I wouldn't bet on it passing... |
alexandre-daubois
approved these changes
Jul 28, 2025
I'd say let's wait for the voting to finish and if it passes, re-target |
|
The RFC won't pass, that's 99,999% sure now. |
xabbuh
reviewed
Jul 31, 2025
| $this->assertTrue(true, $this->resolver->isDefined('foo')); | ||
| $this->assertTrue(true, $this->resolver->isDeprecated('foo')); | ||
| $this->assertTrue(true, $this->resolver->hasDefault('foo')); | ||
| $this->assertTrue($this->resolver->isDefined('foo')); |
There was a problem hiding this comment.
As a fix to an older branch as this is clearly a bug in the test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No real bug fixed but still edge cases that are better handled explicitly.
This is both a subset and a superset of #60890 by @Girgias
It fixes all spots reported by php/php-src#18879 that can be consider as legit to me.