[FrameworkBundle] Add support for union types on #[AsEventListener]
#61252
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f33247 to
a69f5dd
Compare
#[AsEventListener]
#[AsEventListener]#[AsEventListener]
There should be tests for the |
|
Hi @derrabus, thanks for the reply! The only tests I found are in RegisterListenerPassTest. Is that the right place to add mine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation to support union types, related to issue #61218 and PR #61222.
It duplicates
kernel.event_listenertags.I'm not sure how to add tests for this — could you advise?