Turn fabbot into a reusable github action #61256
Merged
+255
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f72521b to
5c94873
Compare
5c94873 to
22cec79
Compare
|
Would this make sense to extract the action in a dedicated repo (in Symfony-tools maybe?) in order to be able to reuse it more easily? but maybe in a second iteration? |
|
@tucksaun that's possible but any repo fits, so it's also fine here I believe: it should make it easier to tweak the action and improve it. |
nicolas-grekas
added a commit
to twigphp/Twig
that referenced
this pull request
Jul 29, 2025
This PR was merged into the 3.x branch. Discussion ---------- Enable Fabbot as a GHA Follows symfony/symfony#61256 Commits ------- a1ea8ed Enable Fabbot as a GHA
nicolas-grekas
added a commit
that referenced
this pull request
Jul 29, 2025
This PR was merged into the 6.4 branch. Discussion ---------- Leverage symfony-tools/fabbot | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follows #61256 Having fabbot in another repo allows proper referencing of the workflow. This is especially important for repositories that are not symfony/symfony Commits ------- 42a44ac Leverage symfony-tools/fabbot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's move CS checks currently done by the remote app into a github action. This will remove the current bottleneck related to its maintenance, since only a few of us have access to fabbot's private repo + host.
You can see this running at nicolas-grekas#46