Skip to content

[Console] Expand LockableTrait API #61273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 7.4
Choose a base branch
from
Open

[Console] Expand LockableTrait API #61273

wants to merge 2 commits into from

Conversation

MakarMS
Copy link

@MakarMS MakarMS commented Jul 30, 2025 •
edited
Loading

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
License MIT

This change safely extends the lock() method to allow manual control over lock release in the parent process.
This is necessary when the main process forks: the previously introduced automatic lock release (enabled by default) triggers upon the destruction of the lock object. As a result, when a forked child process terminates, it unintentionally releases the lock for all processes.

This update ensures that lock release can be explicitly managed to avoid premature unlocking in such scenarios.

@MakarMS MakarMS requested a review from chalasr as a code owner July 30, 2025 10:52
@carsonbot carsonbot added this to the 7.4 milestone Jul 30, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "feature/expand-lockabletrait-api on 7.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@MakarMS MakarMS changed the title feat: Expand LockableTrait API [Component] Expand LockableTrait API Jul 30, 2025
@MakarMS MakarMS changed the title [Component] Expand LockableTrait API [Console] Expand LockableTrait API Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Feature Status: Needs Review
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
2 participants
@MakarMS @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy