[Messenger] Remove fix NoAutoAckStamp handling in Worker::flush()
#61291
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker::flush() method
|
This PR not only removes unused code, but changes code. Can you please add or modify an existing test case? Thanks |
1d1766d to
bb580f1
Compare
Worker::flush() methodNoAutoAckStamp handling in Worker::flush()
NoAutoAckStamp handling in Worker::flush()NoAutoAckStamp handling in Worker::flush()
NoAutoAckStamp handling in Worker::flush()NoAutoAckStamp handling in Worker::flush()
bb580f1 to
1d3caf6
Compare
|
That's the best I could come up with. Using only minimal Reflection to fill the |
The line `$envelope = $envelope->withoutAll(NoAutoAckStamp::class);` was modifying a local variable that was never used after assignment. This change moves the stamp removal to the catch block where it's actually needed, ensuring envelopes stored for acknowledgment don't contain contradictory NoAutoAckStamp.
1d3caf6 to
06b1d8f
Compare
nicolas-grekas
approved these changes
Aug 4, 2025
|
Thank you @wazum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unused code in the
Worker::flush()method where an envelope modification was never used.Changes
$envelope = $envelope->withoutAll(NoAutoAckStamp::class);which was modifying a local variable that was immediately discardedNoAutoAckStampremoval to the catch block where it's actually neededWhy this change?
The line was unused code because:
dispatch()succeeds: The modified envelope is never used (foreach continues/ends)dispatch()throws: The line is never reachedMoving the stamp removal to the
catchblock ensures that envelopes stored for acknowledgment have clean state - they shouldn't contain a "no auto ack" stamp when they're about to be acknowledged.