[Messenger] Fix BatchHandlerTrait::flush()
ignoring force
parameter
#61293
+62
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flush() method was ignoring the $force parameter and always flushing when jobs existed, violating the
BatchHandlerInterface
contract which states flushing "can be skipped if not" forced.This caused inefficient batching behavior where flush(false) calls during worker idle periods would prematurely process partial batches instead of waiting for the batch size threshold to be reached.
What it does
Fixes
BatchHandlerTrait::flush(bool $force)
to respect the$force
parameter:flush(false)
andflush(true)
behaved identically - always flushed when jobs existedflush(false)
only flushes whenshouldFlush()
returns true (batch size reached)Example
Impact
This fixes the Worker's flush behavior during idle periods:
Worker::run()
callsflush(false)
when no messages are handled