[FrameworkBundle] Fix block type from OK to ERROR when local vault is disabled in SecretsGenerateKeysCommand
#61317
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This error does not appear to be related to the changes introduced in this PR. |
OK to ERROR when local vault is disabled in SecretsDecryptToLocalCommandOK to ERROR when local vault is disabled in SecretsGenerateKeysCommand
…t is disabled in `SecretsGenerateKeysCommand`
2db6946 to
96ea591
Compare
OskarStark
approved these changes
Aug 4, 2025
alexandre-daubois
approved these changes
Aug 4, 2025
|
Thank you @santysisi. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 5, 2025
…en local vault is disabled in `SecretsRemoveCommand` (santysisi) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Fix block type from `OK` to `ERROR` when local vault is disabled in `SecretsRemoveCommand` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | no | License | MIT Minor: fix block type from `OK` to `ERROR` when local vault is disabled in `SecretsRemoveCommand` [Reference](#61317) Commits ------- ac7821e [FrameworkBundle] Fix block type from `OK` to `ERROR` when local vault is disabled in `SecretsRemoveCommand`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor: fix block type from
OKtoERRORwhen local vault is disabled inSecretsDecryptToLocalCommandReferences: