Skip to content

[Console] [Table] Don't split grapheme clusters #61319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

[Console] [Table] Don't split grapheme clusters #61319

merged 1 commit into from
Aug 4, 2025
+3 −1

Conversation

schlndh
Copy link
Contributor

@schlndh schlndh commented Aug 4, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

This change prevents splitting of grapheme clusters due to wrapping in Table. The emoji consists of multiple code points, so CodePointString chunked it into multiple pieces and wordrap then split them into separate lines. E.g.:

--- Expected
+++ Actual
@@ @@
-'👩‍🌾'
+'👩
+‍
+🌾'

@schlndh schlndh requested a review from chalasr as a code owner August 4, 2025 07:59
@carsonbot carsonbot added this to the 6.4 milestone Aug 4, 2025
@carsonbot carsonbot changed the title [Console][Table] Don't split grapheme clusters [Console] [Table] Don't split grapheme clusters Aug 4, 2025
@schlndh schlndh force-pushed the fix-dontSplitGraphemeCluster branch from 965e5cf to c258c19 Compare August 4, 2025 08:03
@nicolas-grekas
Copy link
Member

Thank you @schlndh.

@nicolas-grekas nicolas-grekas merged commit cfe2fcc into symfony:6.4 Aug 4, 2025
10 of 11 checks passed
@schlndh schlndh deleted the fix-dontSplitGraphemeCluster branch August 4, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@schlndh @nicolas-grekas @fabpot @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy