Skip to content

[JsonStreamer] fix expected stream to native value transformers #61323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 4, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

This was probably a copy-and-paste mistake from the corresponding write test. With PHPUnit < 12.0 this isn't an issue as closure are not considered when testing for equality. This changes with PHPUnit 12 where sebastian/comparator 7 is used which also compares closures.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 1df3a3d into symfony:7.3 Aug 4, 2025
15 of 17 checks passed
@xabbuh xabbuh deleted the pr-51718 branch August 4, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy