Skip to content

[Ldap][Messenger][Validator][Workflow] Add methods to interfaces as planned #61324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: |
$env:Path = 'c:\php;' + $env:Path
mkdir c:\php && cd c:\php
iwr -outf php.zip https://github.com/symfony/binary-utils/releases/download/v0.1/php-8.2.0-Win32-vs16-x86.zip
iwr -outf php.zip https://github.com/symfony/binary-utils/releases/download/v0.1/php-8.4.0-Win32-vs17-x86.zip
7z x php.zip -y >nul
Copy php.ini-development php.ini
"memory_limit=-1" >> php.ini
Expand All @@ -66,6 +66,7 @@ jobs:

$env:SYMFONY_VERSION=(Select-String -CaseSensitive -Pattern " VERSION =" -SimpleMatch -Path src/Symfony/Component/HttpKernel/Kernel.php | Select Line | Select-String -Pattern "([0-9][0-9]*\.[0-9])").Matches.Value
$env:COMPOSER_ROOT_VERSION=$env:SYMFONY_VERSION + ".x-dev"
$env:COMPOSER_ROOT_VERSION="7.4.x-dev" # to be removed once all deps allow ^8.0

php .github/build-packages.php HEAD^ $env:SYMFONY_VERSION src\Symfony\Bridge\PhpUnit
php composer.phar update --no-progress --ansi
Expand Down
4 changes: 4 additions & 0 deletions UPGRADE-8.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ Ldap

* Remove the `sizeLimit` option of `AbstractQuery`
* Remove `LdapUser::eraseCredentials()` in favor of `__serialize()`
* Add methods for `saslBind()` and `whoami()` to `ConnectionInterface` and `LdapInterface`

Mailer
------
Expand All @@ -215,6 +216,7 @@ Messenger
---------

* Remove `text` format when using the `messenger:stats` command
* Add method `getRetryDelay()` to `RecoverableExceptionInterface`

Notifier
--------
Expand Down Expand Up @@ -489,6 +491,7 @@ Uid
Validator
---------

* Add method `getGroupProvider()` to `ClassMetadataInterface`
* Remove the `getRequiredOptions()` and `getDefaultOption()` methods from the `All`, `AtLeastOneOf`, `CardScheme`, `Collection`,
`CssColor`, `Expression`, `Regex`, `Sequentially`, `Type`, and `When` constraints
* Remove support for evaluating options in the base `Constraint` class. Initialize properties in the constructor of the concrete constraint
Expand Down Expand Up @@ -622,6 +625,7 @@ WebProfilerBundle
Workflow
--------

* Add method `getEnabledTransition()` to `WorkflowInterface`
* Add `$nbToken` argument to `Marking::mark()` and `Marking::unmark()`
* Remove `Event::getWorkflow()` method

Expand Down
7 changes: 2 additions & 5 deletions src/Symfony/Component/Ldap/Adapter/ConnectionInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@

/**
* @author Charles Sarrazin <charles@sarraz.in>
*
* @method void saslBind(?string $dn = null, #[\SensitiveParameter] ?string $password = null, ?string $mech = null, ?string $realm = null, ?string $authcId = null, ?string $authzId = null, ?string $props = null)
* @method string whoami()
*/
interface ConnectionInterface
{
Expand All @@ -45,10 +42,10 @@ public function bind(?string $dn = null, #[\SensitiveParameter] ?string $passwor
* @throws ConnectionTimeoutException When the connection can't be created because of an LDAP_TIMEOUT error
* @throws InvalidCredentialsException When the connection can't be created because of an LDAP_INVALID_CREDENTIALS error
*/
// public function saslBind(?string $dn = null, #[\SensitiveParameter] ?string $password = null, ?string $mech = null, ?string $realm = null, ?string $authcId = null, ?string $authzId = null, ?string $props = null): void;
public function saslBind(?string $dn = null, #[\SensitiveParameter] ?string $password = null, ?string $mech = null, ?string $realm = null, ?string $authcId = null, ?string $authzId = null, ?string $props = null): void;

/*
* Return authenticated and authorized (for SASL) DN.
*/
// public function whoami(): string;
public function whoami(): string;
}
1 change: 1 addition & 0 deletions src/Symfony/Component/Ldap/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ CHANGELOG

* Remove the `sizeLimit` option of `AbstractQuery`
* Remove `LdapUser::eraseCredentials()` in favor of `__serialize()`
* Add methods for `saslBind()` and `whoami()` to `ConnectionInterface` and `LdapInterface`

7.3
---
Expand Down
7 changes: 2 additions & 5 deletions src/Symfony/Component/Ldap/LdapInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@

/**
* @author Charles Sarrazin <charles@sarraz.in>
*
* @method void saslBind(?string $dn = null, #[\SensitiveParameter] ?string $password = null, ?string $mech = null, ?string $realm = null, ?string $authcId = null, ?string $authzId = null, ?string $props = null)
* @method string whoami()
*/
interface LdapInterface
{
Expand All @@ -38,12 +35,12 @@ public function bind(?string $dn = null, #[\SensitiveParameter] ?string $passwor
*
* @throws ConnectionException if dn / password could not be bound
*/
// public function saslBind(?string $dn = null, #[\SensitiveParameter] ?string $password = null, ?string $mech = null, ?string $realm = null, ?string $authcId = null, ?string $authzId = null, ?string $props = null): void;
public function saslBind(?string $dn = null, #[\SensitiveParameter] ?string $password = null, ?string $mech = null, ?string $realm = null, ?string $authcId = null, ?string $authzId = null, ?string $props = null): void;

/**
* Returns authenticated and authorized (for SASL) DN.
*/
// public function whoami(): string;
public function whoami(): string;

/**
* Queries a ldap server for entries matching the given criteria.
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Messenger/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ CHANGELOG
---

* Remove `text` format when using the `messenger:stats` command; use `txt` instead
* Add method `getRetryDelay()` to `RecoverableExceptionInterface`

7.4
---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@
* and the message should be retried, a handler can throw such an exception.
*
* @author Jérémy Derussé <jeremy@derusse.com>
*
* @method int|null getRetryDelay() The time to wait in milliseconds
*/
interface RecoverableExceptionInterface extends \Throwable
{
/**
* Returns the time to wait before potentially retrying, in millisecond.
*/
public function getRetryDelay(): ?int;
}
1 change: 1 addition & 0 deletions src/Symfony/Component/Validator/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ CHANGELOG
8.0
---

* Add method `getGroupProvider()` to `ClassMetadataInterface`
* Remove the `getRequiredOptions()` and `getDefaultOption()` methods from the `All`, `AtLeastOneOf`, `CardScheme`, `Collection`,
`CssColor`, `Expression`, `Regex`, `Sequentially`, `Type`, and `When` constraints
* Remove support for evaluating options in the base `Constraint` class. Initialize properties in the constructor of the concrete constraint
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
* @see GroupSequence
* @see GroupSequenceProviderInterface
* @see TraversalStrategy
*
* @method string|null getGroupProvider()
*/
interface ClassMetadataInterface extends MetadataInterface
{
Expand Down Expand Up @@ -66,6 +64,8 @@ public function getGroupSequence(): ?GroupSequence;
*/
public function isGroupSequenceProvider(): bool;

public function getGroupProvider(): ?string;

/**
* Check if there's any metadata attached to the given named property.
*
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Workflow/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ CHANGELOG
8.0
---

* Add method `getEnabledTransition()` to `WorkflowInterface`
* Add `$nbToken` argument to `Marking::mark()` and `Marking::unmark()`
* Remove `Event::getWorkflow()` method

Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Workflow/WorkflowInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
* Describes a workflow instance.
*
* @author Amrouche Hamza <hamza.simperfit@gmail.com>
*
* @method Transition|null getEnabledTransition(object $subject, string $name)
*/
interface WorkflowInterface
{
Expand Down Expand Up @@ -58,6 +56,8 @@ public function apply(object $subject, string $transitionName, array $context =
*/
public function getEnabledTransitions(object $subject): array;

public function getEnabledTransition(object $subject, string $name): ?Transition;

public function getName(): string;

public function getDefinition(): Definition;
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy