[FrameworkBundle] Decouple ControllerResolverTest from HttpKernel #61328
+2
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Aug 4, 2025
…ttpKernel (nicolas-grekas) This PR was merged into the 7.4 branch. Discussion ---------- [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Using non-public API for cross-components test case dependencies complicates maintenance. Commits ------- 4e9c9c1 [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel
nicolas-grekas
added a commit
that referenced
this pull request
Aug 5, 2025
* 7.3: [Scheduler] Fix `scheduler.task` tag arguments optionality use false instead of null to hide the currency symbol [FrameworkBundle] Fix block type from `OK` to `ERROR` when local vault is disabled in `SecretsRemoveCommand` Fix wrong boolean values minor #61328 [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel (nicolas-grekas) [Messenger] Fix NoAutoAckStamp handling in Worker::flush()
nicolas-grekas
added a commit
that referenced
this pull request
Aug 5, 2025
* 7.4: Use phpunit attribute Remove some implicit bool type juggling [Scheduler] Fix `scheduler.task` tag arguments optionality use false instead of null to hide the currency symbol [FrameworkBundle] Fix block type from `OK` to `ERROR` when local vault is disabled in `SecretsRemoveCommand` run tests with PHPUnit 12.1 on PHP >= 8.3 Fix wrong boolean values minor #61328 [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel (nicolas-grekas) [Messenger] Fix NoAutoAckStamp handling in Worker::flush() [DependencyInjection] Dump XML using plain PHP, no DOM needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using non-public API for cross-components test case dependencies complicates maintenance.