run tests with PHPUnit 12.1 on PHP >= 8.3 #61333
Merged
+29
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 4, 2025
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
|
Status: Needs work |
xabbuh
commented
Aug 4, 2025
|
|
||
| $this->assertSamePath(\PHP_BINARY, $result); | ||
| } finally { | ||
| ini_set('open_basedir', $initialOpenBaseDir); |
There was a problem hiding this comment.
This never used to work as expected as you cannot widen the open basedir restrictions after tightening it before. Later on when PHPUnit cleaned up the test environment this led to a PHP warning which in turn lets the test fail:
src/Symfony/Component/Process 19s
+ /home/runner/work/symfony/symfony/phpunit --exclude-group tty --exclude-group benchmark --exclude-group intl-data --exclude-group integration --exclude-group transient src/Symfony/Component/Process
PHPUnit 12.1.6 by Sebastian Bergmann and contributors.
Runtime: PHP 8.3.23
Configuration: /home/runner/work/symfony/symfony/phpunit.xml.dist
........WS.S................................................... 63 / 186 ( 33%)
...................SSS......................................... 126 / 186 ( 67%)
...........................................................S 186 / 186 (100%)
Time: 00:19.259, Memory: 16.00 MB
1 test triggered 1 PHP warning:
1) /home/runner/work/symfony/symfony/.phpunit/phpunit-12.1-0/src/Framework/TestCase.php:1290
ini_set(): open_basedir restriction in effect. File() is not within the allowed path(s): (/usr/bin:/)
Triggered by:
* Symfony\Component\Process\Tests\ExecutableFinderTest::testFindWithOpenBaseDir
/home/runner/work/symfony/symfony/src/Symfony/Component/Process/Tests/ExecutableFinderTest.php:115
|
Status: Needs Review |
|
Why not 12.3? |
|
That's the ultimate goal, but we have to fix issues with every minor update we do for PHPUnit. That's why I am doing it step by step. |
derrabus
approved these changes
Aug 5, 2025
OskarStark
approved these changes
Aug 5, 2025
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.