Skip to content

[Lock] - replace getExpiringDate by getRemainingLifetime #14644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

[Lock] - replace getExpiringDate by getRemainingLifetime #14644

merged 1 commit into from
Dec 11, 2020

Conversation

ybenhssaien
Copy link
Contributor

As the method getExpiringDate doesn't exist, replace it by getRemainingLifetime which returns the remaining time to live in seconds

@ybenhssaien ybenhssaien changed the title Lock - replace getExpiringDate by getRemainingLifetime [Lock] - replace getExpiringDate by getRemainingLifetime Dec 3, 2020
@OskarStark OskarStark added the Lock label Dec 4, 2020
@javiereguiluz javiereguiluz added this to the 4.4 milestone Dec 11, 2020
@javiereguiluz
Copy link
Member

This can be verified at: https://github.com/symfony/symfony/blob/278688deeb27e02836fc960cbae71dcffd5f90e7/src/Symfony/Component/Lock/LockInterface.php#L72

Thanks Youssef!

@ybenhssaien @javiereguiluz
Lock - replace getExpiringDate by getRemainingLifetime
f812114 
As the method `getExpiringDate` doesn't exist, replace it by `getRemainingLifetime` which returns the remaining time to live in seconds
@javiereguiluz javiereguiluz changed the base branch from 5.2 to 4.4 December 11, 2020 15:20
@javiereguiluz javiereguiluz merged commit dab151b into symfony:4.4 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Lock Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ybenhssaien @javiereguiluz @OskarStark @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy